Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1096)

Issue 6353051: code review 6353051: syscall: add PtraceSyscall(pid int, signal int) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by dfc
Modified:
11 years, 6 months ago
Reviewers:
CC:
golang-dev, r, rsc
Visibility:
Public.

Description

syscall: add PtraceSyscall(pid int, signal int) Fixes issue 3525. PTRACE_SYSCALL behaves like PTRACE_CONT and can deliver a signal to the process. Ideally PtraceSingleStep should support the signal argument, but its interface is frozen by Go1.

Patch Set 1 #

Patch Set 2 : diff -r f8a77e2b7d0b https://code.google.com/p/go #

Patch Set 3 : diff -r 989f373141cc https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 30d7ee9da51d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 30d7ee9da51d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/pkg/syscall/syscall_linux.go View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 7 months ago (2012-08-21 02:27:42 UTC) #1
r
http://codereview.appspot.com/6353051/diff/5001/src/pkg/syscall/syscall_linux.go File src/pkg/syscall/syscall_linux.go (right): http://codereview.appspot.com/6353051/diff/5001/src/pkg/syscall/syscall_linux.go#newcode740 src/pkg/syscall/syscall_linux.go:740: } What's wrong with Ptrace as a name?
11 years, 7 months ago (2012-08-21 04:38:32 UTC) #2
dfc
> src/pkg/syscall/syscall_linux.go:740: } > What's wrong with Ptrace as a name? Nothing really. I was ...
11 years, 7 months ago (2012-08-21 04:57:50 UTC) #3
rsc
LGTM http://codereview.appspot.com/6353051/diff/5001/src/pkg/syscall/syscall_linux.go File src/pkg/syscall/syscall_linux.go (right): http://codereview.appspot.com/6353051/diff/5001/src/pkg/syscall/syscall_linux.go#newcode740 src/pkg/syscall/syscall_linux.go:740: } On 2012/08/21 04:38:32, r wrote: > What's ...
11 years, 7 months ago (2012-08-31 16:40:55 UTC) #4
dfc
11 years, 7 months ago (2012-08-31 23:17:39 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=827bc3cff650 ***

syscall: add PtraceSyscall(pid int, signal int)

Fixes issue 3525.

PTRACE_SYSCALL behaves like PTRACE_CONT and can deliver
a signal to the process. Ideally PtraceSingleStep should
support the signal argument, but its interface is frozen
by Go1.

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/6353051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b