Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2662)

Issue 6326054: code review 6326054: cmd/ld: add PT_PAX_FLAGS ELF header (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by rsc
Modified:
11 years, 8 months ago
Reviewers:
minux1
CC:
iant, golang-dev
Visibility:
Public.

Description

cmd/ld: add PT_PAX_FLAGS ELF header PAX systems are Linux systems that are more paranoid about memory permissions. These flags tell them to relax when running Go binaries. Fixes issue 47.

Patch Set 1 #

Patch Set 2 : diff -r 73dfe1ecc9ac https://code.google.com/p/go/ #

Patch Set 3 : diff -r 73dfe1ecc9ac https://code.google.com/p/go/ #

Patch Set 4 : diff -r 30dfc01b473c https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r 16ea5989afbe https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/cmd/6l/asm.c View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/cmd/8l/asm.c View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M src/cmd/ld/elf.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 8 months ago (2012-08-03 18:02:27 UTC) #1
iant
LGTM http://codereview.appspot.com/6326054/diff/7001/src/cmd/8l/asm.c File src/cmd/8l/asm.c (right): http://codereview.appspot.com/6326054/diff/7001/src/cmd/8l/asm.c#newcode1133 src/cmd/8l/asm.c:1133: ph->align = 8; s/8/4/
11 years, 8 months ago (2012-08-03 18:31:38 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=5099eaeb3086 *** cmd/ld: add PT_PAX_FLAGS ELF header PAX systems are Linux systems ...
11 years, 8 months ago (2012-08-03 19:27:38 UTC) #3
minux1
i think we also need to add PT_PAX_FLAGS generation to 5l, because Linux/ARM system also ...
11 years, 8 months ago (2012-08-06 01:53:25 UTC) #4
rsc
On Sun, Aug 5, 2012 at 9:53 PM, <minux.ma@gmail.com> wrote: > i think we also ...
11 years, 8 months ago (2012-08-06 19:45:56 UTC) #5
minux1
11 years, 8 months ago (2012-08-07 16:01:40 UTC) #6
On Tue, Aug 7, 2012 at 3:45 AM, Russ Cox <rsc@golang.org> wrote:

> On Sun, Aug 5, 2012 at 9:53 PM,  <minux.ma@gmail.com> wrote:
> > i think we also need to add PT_PAX_FLAGS generation to 5l,
> > because Linux/ARM system also has limited PAX support,
> > we could do this now to prevent future frustrations.
> sounds good to me. want to do it?
>
http://codereview.appspot.com/6453092/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b