Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(780)

Issue 6304087: code review 6304087: run.bash: increase test timeout for ARMv5 systems (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by dfc
Modified:
11 years, 9 months ago
Visibility:
Public.

Description

run.bash: increase test timeout for ARMv5 systems Fixes issue 3740. Increase the test timeout by 50% for ARMv5 systems or those using softfloat math. Addresses an issue with the 700Mhz Raspberry Pi which takes ~150s for math/rand.

Patch Set 1 #

Patch Set 2 : diff -r 5e3661048f2e https://code.google.com/p/go #

Patch Set 3 : diff -r 5e3661048f2e https://code.google.com/p/go #

Patch Set 4 : diff -r 5e3661048f2e https://code.google.com/p/go #

Patch Set 5 : diff -r b5c4f411a852 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/run.bash View 1 2 3 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 9 months ago (2012-07-02 02:06:40 UTC) #1
minux1
LGTM.
11 years, 9 months ago (2012-07-02 02:17:58 UTC) #2
remyoudompheng
As rsc commented on issue 3740, the tests should probably be fixed instead. I'm surprised ...
11 years, 9 months ago (2012-07-02 07:18:27 UTC) #3
dfc
What about http://codereview.appspot.com/6351058 ok math/rand 11.402s real 0m19.493s user 0m19.150s sys 0m0.620s On Mon, Jul ...
11 years, 9 months ago (2012-07-02 10:57:02 UTC) #4
dfc
11 years, 9 months ago (2012-07-02 12:01:22 UTC) #5
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b