Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1293)

Issue 6303106: code review 6303106: net: fix lookup of AAAA-only hosts without cgo

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by mstplbrg
Modified:
11 years, 9 months ago
Reviewers:
rsc
CC:
rsc, golang-dev
Visibility:
Public.

Description

net: fix lookup of AAAA-only hosts without cgo Fixes issue 3762.

Patch Set 1 #

Patch Set 2 : diff -r f14046c7d922 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f14046c7d922 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f14046c7d922 https://go.googlecode.com/hg/ #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M src/pkg/net/dnsclient_unix.go View 1 2 3 1 chunk +17 lines, -11 lines 5 comments Download

Messages

Total messages: 11
mstplbrg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 9 months ago (2012-06-24 13:38:49 UTC) #1
rsc
This code looks like it is duplicating the actions carried out just a few lines ...
11 years, 9 months ago (2012-06-24 23:21:12 UTC) #2
mstplbrg
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 9 months ago (2012-06-25 15:00:07 UTC) #3
rsc
http://codereview.appspot.com/6303106/diff/6002/src/pkg/net/dnsclient_unix.go File src/pkg/net/dnsclient_unix.go (right): http://codereview.appspot.com/6303106/diff/6002/src/pkg/net/dnsclient_unix.go#newcode243 src/pkg/net/dnsclient_unix.go:243: if cname != "" { Do we need a ...
11 years, 9 months ago (2012-06-25 20:46:37 UTC) #4
mstplbrg
http://codereview.appspot.com/6303106/diff/6002/src/pkg/net/dnsclient_unix.go File src/pkg/net/dnsclient_unix.go (right): http://codereview.appspot.com/6303106/diff/6002/src/pkg/net/dnsclient_unix.go#newcode243 src/pkg/net/dnsclient_unix.go:243: if cname != "" { On 2012/06/25 20:46:37, rsc ...
11 years, 9 months ago (2012-06-25 21:07:44 UTC) #5
rsc
http://codereview.appspot.com/6303106/diff/6002/src/pkg/net/dnsclient_unix.go File src/pkg/net/dnsclient_unix.go (right): http://codereview.appspot.com/6303106/diff/6002/src/pkg/net/dnsclient_unix.go#newcode243 src/pkg/net/dnsclient_unix.go:243: if cname != "" { On 2012/06/25 21:07:44, mstplbrg ...
11 years, 9 months ago (2012-06-25 21:16:49 UTC) #6
mstplbrg
http://codereview.appspot.com/6303106/diff/6002/src/pkg/net/dnsclient_unix.go File src/pkg/net/dnsclient_unix.go (right): http://codereview.appspot.com/6303106/diff/6002/src/pkg/net/dnsclient_unix.go#newcode243 src/pkg/net/dnsclient_unix.go:243: if cname != "" { On 2012/06/25 21:16:49, rsc ...
11 years, 9 months ago (2012-06-25 21:20:16 UTC) #7
rsc
LGTM http://codereview.appspot.com/6303106/diff/6002/src/pkg/net/dnsclient_unix.go File src/pkg/net/dnsclient_unix.go (right): http://codereview.appspot.com/6303106/diff/6002/src/pkg/net/dnsclient_unix.go#newcode243 src/pkg/net/dnsclient_unix.go:243: if cname != "" { Never mind, you're ...
11 years, 9 months ago (2012-06-25 21:23:10 UTC) #8
rsc
I don't see your CLA on file. Did you use a different email address? That's ...
11 years, 9 months ago (2012-06-25 21:26:21 UTC) #9
mstplbrg
On Mon, Jun 25, 2012 at 11:26 PM, Russ Cox <rsc@golang.org> wrote: > I don't ...
11 years, 9 months ago (2012-06-25 21:27:11 UTC) #10
rsc
11 years, 9 months ago (2012-06-25 21:32:42 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=11d959e6961f ***

net: fix lookup of AAAA-only hosts without cgo

Fixes issue 3762.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6303106

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b