Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(711)

Issue 6197091: misc/emacs: make compilation-mode's next-error understand test failure output

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by ryanb
Modified:
11 years, 10 months ago
Reviewers:
Sameer Ajmani
CC:
golang-dev, rsc, Sameer Ajmani, jba
Visibility:
Public.

Description

misc/emacs: make compilation-mode's next-error understand test failure output. specifically, adds a go-test element to compilation-error-regexp-alist[-alist]. Fixes issue 3629.

Patch Set 1 : misc/emacs: make next-error support test and panic output #

Patch Set 2 : freshly synched copy of patch #1 #

Patch Set 3 : new fresh patch (synched past issue 6213056's cl) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M misc/emacs/go-mode.el View 1 2 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 12
ryanb
hi all! this is pretty small and straightforward, and it fixes http://code.google.com/p/go/issues/detail?id=3629 . thanks in ...
11 years, 10 months ago (2012-05-16 16:14:50 UTC) #1
rsc
+jba
11 years, 10 months ago (2012-05-17 01:54:30 UTC) #2
ryanb
(actually +jba)
11 years, 10 months ago (2012-05-18 21:02:30 UTC) #3
ryanb
this update patch supports panic stack traces too.
11 years, 10 months ago (2012-05-26 22:10:48 UTC) #4
Sameer Ajmani
LGTM
11 years, 10 months ago (2012-05-31 15:34:20 UTC) #5
Sameer Ajmani
On 2012/05/31 15:34:20, Sameer Ajmani wrote: > LGTM Hi Ryan, Please sync and upload a ...
11 years, 10 months ago (2012-05-31 15:39:59 UTC) #6
ryanb
On Thu, May 31, 2012 at 8:39 AM, <sameer@golang.org> wrote: > > Please sync and ...
11 years, 10 months ago (2012-05-31 23:42:19 UTC) #7
Sameer Ajmani
On 2012/05/31 23:42:19, ryanb wrote: > On Thu, May 31, 2012 at 8:39 AM, <mailto:sameer@golang.org> ...
11 years, 10 months ago (2012-06-01 21:09:29 UTC) #8
ryanb
On Fri, Jun 1, 2012 at 2:09 PM, <sameer@golang.org> wrote: > > I still cannot ...
11 years, 10 months ago (2012-06-01 22:07:00 UTC) #9
Sameer Ajmani
*** Submitted as http://code.google.com/p/go/source/detail?r=f469c9d212c4 *** misc/emacs: make compilation-mode's next-error understand test failure output. specifically, adds ...
11 years, 10 months ago (2012-06-04 14:36:50 UTC) #10
ryanb
thank you! i'm enjoying go so far, and good tool support helps a lot. these ...
11 years, 10 months ago (2012-06-04 15:04:15 UTC) #11
Sameer Ajmani
11 years, 10 months ago (2012-06-04 16:04:08 UTC) #12
I'm grateful to have people involved now who actually know elisp well :-)
On Jun 4, 2012 11:04 AM, "Ryan Barrett" <ryanb@google.com> wrote:

> thank you! i'm enjoying go so far, and good tool support helps a lot.
> these were both minor nits; overall, i'm really happy with (and
> grateful for) go-mode.
>
> On Mon, Jun 4, 2012 at 7:36 AM,  <sameer@golang.org> wrote:
> > *** Submitted as
> > http://code.google.com/p/go/source/detail?r=f469c9d212c4 ***
> >
> > misc/emacs: make compilation-mode's next-error understand test failure
> > output.
> >
> > specifically, adds a go-test element to
> > compilation-error-regexp-alist[-alist].
> > Fixes issue 3629.
> >
> > R=golang-dev, rsc, sameer
> > CC=golang-dev, jba
> > http://codereview.appspot.com/6197091
> >
> > Committer: Sameer Ajmani <sameer@golang.org>
> >
> >
> > http://codereview.appspot.com/6197091/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b