Issue 6137054: code review 6137054: encoding/base64: don't ignore underlying souce read err...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6137054: code review 6137054: encoding/base64: don't ignore underlying souce read err... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bradfitz

Modified:
12 years ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

encoding/base64: don't ignore underlying souce read error in decode Fixes issue 3577

Patch Set 2 : diff -r 15260ef90c98 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 15260ef90c98 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 15260ef90c98 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -1 line)			Patch
	M	src/pkg/encoding/base64/base64.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/encoding/base64/base64_test.go	View	1 2 3	2 chunks	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2012-04-30 06:52:58 UTC) #1

dsymonds

LGTM nice test http://codereview.appspot.com/6137054/diff/3001/src/pkg/encoding/base64/base64.go File src/pkg/encoding/base64/base64.go (right): http://codereview.appspot.com/6137054/diff/3001/src/pkg/encoding/base64/base64.go#newcode324 src/pkg/encoding/base64/base64.go:324: if d.err != nil { the ...

12 years ago (2012-04-30 07:04:42 UTC) #2

bradfitz

12 years ago (2012-04-30 07:14:51 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=69c9477136d3 ***

encoding/base64: don't ignore underlying souce read error in decode

Fixes issue 3577

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/6137054

Expand All Messages | Collapse All Messages