code review 6048047: encoding/json: allow punctuation in tag names

encoding/json: allow punctuation in tag names

everything except backslash and the quote chars is fair game.

Fixes issue 3546.

[bpowers, 2012-04-18 16:18:35]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bpowers, 2012-04-18 16:28:26]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bpowers, 2012-04-24 18:27:45]

On 2012/04/18 16:28:26, bpowers wrote:
> Hello
https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=golang-dev@googlegroups.com
(cc:
https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=golang-dev@googlegroups.com),
> 
> Please take another look.

ping

[rsc, 2012-04-25 01:53:40]

http://codereview.appspot.com/6048047/diff/6001/src/pkg/encoding/json/encode.go
File src/pkg/encoding/json/encode.go (right):

http://codereview.appspot.com/6048047/diff/6001/src/pkg/encoding/json/encode....
src/pkg/encoding/json/encode.go:419: case '$', '-', '_', '/', '%', '@':
I don't want to come back here each time someone needs a character.
I think we should expand to this set:

!#$%&()*+-./:<=>?@[]^_{|}~

That's the ASCII punctuation except the quote characters and backslash; I want
to reserve those four for our own future use.

[bpowers, 2012-04-25 03:11:14]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[bpowers, 2012-04-25 03:12:56]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-04-25 03:27:35]

LGTM

Will submit tomorrow unless someone beats me to it.

[r, 2012-04-25 03:30:36]

LGTM but please s/punction/punctuation/ in the CL description (use hg change
6048047)

[bpowers, 2012-04-25 04:08:37]

Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2012-04-25 04:34:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=233ff5d46b3d ***

encoding/json: allow punctuation in tag names

everything except backslash and the quote chars is fair game.

Fixes issue 3546.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/6048047

Committer: Rob Pike <r@golang.org>