Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(946)

Issue 6032052: code review 6032052: net/http: add example for StripPrefix, and mention that... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by minux1
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, rsc, bradfitz
Visibility:
Public.

Description

net/http: add example for FileServer to mention StripPrefix Fixes issue 3530.

Patch Set 1 #

Patch Set 2 : diff -r 6c1797405851 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6c1797405851 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c9b5df168d3d https://code.google.com/p/go/ #

Patch Set 5 : diff -r c9b5df168d3d https://code.google.com/p/go/ #

Patch Set 6 : diff -r c9b5df168d3d https://code.google.com/p/go/ #

Patch Set 7 : diff -r b93d51d8ac36 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/pkg/net/http/example_test.go View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 1 month ago (2012-04-15 15:08:42 UTC) #1
rsc
Instead of the redirect, can you make this an example for FileServer? More people will ...
12 years, 1 month ago (2012-04-17 21:12:02 UTC) #2
minux1
On 2012/04/17 21:12:02, rsc wrote: > Instead of the redirect, can you make this an ...
12 years, 1 month ago (2012-04-18 06:45:34 UTC) #3
bradfitz
LGTM On Tue, Apr 17, 2012 at 11:45 PM, <minux.ma@gmail.com> wrote: > On 2012/04/17 21:12:02, ...
12 years, 1 month ago (2012-04-18 13:15:46 UTC) #4
minux1
12 years, 1 month ago (2012-04-19 16:41:23 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=362b760ecfc7 ***

net/http: add example for FileServer to mention StripPrefix
        Fixes issue 3530.

R=golang-dev, rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/6032052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b