Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1217)

Issue 5972048: code review 5972048: compiler: fix infinite recursion in string constant eva... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by remyoudompheng
Modified:
11 years, 11 months ago
Reviewers:
CC:
gofrontend-dev_googlegroups.com, iant, remy_archlinux.org
Visibility:
Public.

Description

compiler: fix infinite recursion in string constant evaluation. Fixes compilation of incorrect code: const f, g = g, f func S() []byte { return []byte(f) } The problem was already handled for numerical constants. Part of issue 3186 (go).

Patch Set 1 #

Patch Set 2 : diff -r 5016046ebbfe https://code.google.com/p/gofrontend/ #

Patch Set 3 : diff -r 5016046ebbfe https://code.google.com/p/gofrontend/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M go/expressions.cc View 1 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 4
remyoudompheng
Hello gofrontend-dev@googlegroups.com (cc: gofrontend-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://code.google.com/p/gofrontend/
12 years ago (2012-03-31 15:15:49 UTC) #1
remyoudompheng
Ping?
12 years ago (2012-04-09 15:25:18 UTC) #2
iant
LGTM Thanks.
12 years ago (2012-04-16 23:03:24 UTC) #3
iant
12 years ago (2012-04-16 23:03:36 UTC) #4
*** Submitted as
http://code.google.com/p/gofrontend/source/detail?r=2ba470ed797c ***

compiler: fix infinite recursion in string constant evaluation.

Fixes compilation of incorrect code:
    const f, g = g, f
    func S() []byte { return []byte(f) }

The problem was already handled for numerical constants.

Part of issue 3186 (go).

R=gofrontend-dev, iant
CC=gofrontend-dev, remy
http://codereview.appspot.com/5972048

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b