Issue 5967057: code review 5967057: cmd/dist, sudo.bash: don't mention sudo.bash if cov and...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5967057: code review 5967057: cmd/dist, sudo.bash: don't mention sudo.bash if cov and... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by minux1

Modified:
12 years ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/dist, sudo.bash: don't mention sudo.bash if cov or prof is not present Fixes issue 3422.

Patch Set 1 #

Patch Set 2 : diff -r fd037b466111 https://code.google.com/p/go/ #

Patch Set 3 : diff -r fd037b466111 https://code.google.com/p/go/ #

Patch Set 4 : diff -r fd037b466111 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 4f9605dc4a10 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	src/cmd/dist/build.c	View	1 2	5 chunks	+8 lines, -5 lines	0 comments	Download
	M	src/sudo.bash	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2012-03-31 17:37:11 UTC) #1

minux1

12 years ago (2012-04-02 14:33:55 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e757e2af45ec ***

cmd/dist, sudo.bash: don't mention sudo.bash if cov or prof is not present
        Fixes issue 3422.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5967057

Expand All Messages | Collapse All Messages