Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(621)

Issue 5848047: code review 5848047: compiler: fix crashes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by remyoudompheng
Modified:
12 years ago
Reviewers:
CC:
gofrontend-dev_googlegroups.com, iant, remy_archlinux.org
Visibility:
Public.

Description

compiler: fix crashes. The compiler would crash on: if true || x, y := 1, 2 {} and var s string s = append(s, "hello") Reported in issue 3186.

Patch Set 1 #

Patch Set 2 : diff -r b626c77ab40e https://code.google.com/p/gofrontend/ #

Patch Set 3 : diff -r b626c77ab40e https://code.google.com/p/gofrontend/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M go/expressions.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M go/parse.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
remyoudompheng
Hello gofrontend-dev@googlegroups.com (cc: gofrontend-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://code.google.com/p/gofrontend/
12 years ago (2012-03-16 21:40:22 UTC) #1
remyoudompheng
Ping?
12 years ago (2012-03-20 19:07:38 UTC) #2
iant
The patch looks fine but I'm freezing gofrontend changes pending the gcc 4.7.0 release.
12 years ago (2012-03-20 20:08:59 UTC) #3
iant
LGTM
12 years ago (2012-03-28 21:30:35 UTC) #4
iant
12 years ago (2012-03-28 21:32:34 UTC) #5
*** Submitted as
http://code.google.com/p/gofrontend/source/detail?r=652c8036e264 ***

compiler: fix crashes.

The compiler would crash on:
        if true || x, y := 1, 2 {}
and
        var s string
        s = append(s, "hello")

Reported in issue 3186.

R=gofrontend-dev, iant
CC=gofrontend-dev, remy
http://codereview.appspot.com/5848047

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b