code review 5845071: cmd/go, go/build, misc/swig: add SWIG support to Go tool

cmd/go, go/build, misc/swig: add SWIG support to Go tool

[iant, 2012-03-19 22:59:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2012-03-20 13:36:41]

On 20 March 2012 09:59,  <iant@golang.org> wrote:
> cmd/go, go/build, misc/swig: add SWIG support to Go tool
>
> We probably do not want to commit this before Go 1 at this
> point.  If we do commit it, it needs a change to api/go1.txt
> for the change to pkg/go/build/build.go

Nice work, but we should definitely hold this til after Go 1.

Andrew

[rsc, 2012-03-26 14:46:51]

Yes, let's hold off until after Go 1.

[fss, 2012-05-22 13:43:47]

Can we back to this CL now that Go 1 is out? Using swig with the go tool would
be nice.

[binet, 2012-06-02 08:27:34]

On 2012/05/22 13:43:47, fsouza wrote:
> Can we back to this CL now that Go 1 is out? Using swig with the go tool would
> be nice.

would this go into a 1.0.2 or (later on) into a 1.1 ?

[adg, 2012-06-04 03:55:04]

On 2012/06/02 08:27:34, binet wrote:
> On 2012/05/22 13:43:47, fsouza wrote:
> > Can we back to this CL now that Go 1 is out? Using swig with the go tool
would
> > be nice.
> 
> would this go into a 1.0.2 or (later on) into a 1.1 ?

This is too big for a point release. It will wait until 1.1, at the earliest.

[adg, 2012-06-04 03:55:20]

On 2012/06/04 03:55:04, adg wrote:
> On 2012/06/02 08:27:34, binet wrote:
> > On 2012/05/22 13:43:47, fsouza wrote:
> > > Can we back to this CL now that Go 1 is out? Using swig with the go tool
> would
> > > be nice.
> > 
> > would this go into a 1.0.2 or (later on) into a 1.1 ?
> 
> This is too big for a point release. It will wait until 1.1, at the earliest.

And by "point release" I mean "minor point release."

[genbattle, 2012-06-26 00:12:21]

On 2012/06/04 03:55:20, adg wrote:
> On 2012/06/04 03:55:04, adg wrote:
> > On 2012/06/02 08:27:34, binet wrote:
> > > On 2012/05/22 13:43:47, fsouza wrote:
> > > > Can we back to this CL now that Go 1 is out? Using swig with the go tool
> > would
> > > > be nice.
> > > 
> > > would this go into a 1.0.2 or (later on) into a 1.1 ?
> > 
> > This is too big for a point release. It will wait until 1.1, at the
earliest.
> 
> And by "point release" I mean "minor point release."

Could this be merged into tip, or is it going to be withheld completely until
the next minor/major release is being prepared? It might even need some more
work by now because of interim changes to Go since the patch set was last
submitted.

Some awareness of this patch has been raised due to discussion on golang-nuts:
https://groups.google.com/forum/?fromgroups#!topic/golang-nuts/vKZwnj54YiU

[rsc, 2012-06-26 00:16:06]

On Mon, Jun 25, 2012 at 8:12 PM,  <gen.battle@gmail.com> wrote:
> Could this be merged into tip, or is it going to be withheld completely
> until the next minor/major release is being prepared?

Yes, merging it into tip is the next step. We are just busy and behind
on code reviews.

Russ

[rsc, 2012-08-03 20:11:56]

LGTM

I am fine with the API changes here. I trust you on the rest of the details. :-)

[iant, 2012-08-04 01:09:02]

*** Submitted as http://code.google.com/p/go/source/detail?r=422b4a8160bc ***

cmd/go, go/build, misc/swig: add SWIG support to Go tool

R=adg, rsc, franciscossouza, seb.binet, gen.battle
CC=golang-dev
http://codereview.appspot.com/5845071