code review 5796068: cmd/go: stop using $GOROOT and $GOBIN in script output

cmd/go: stop using $GOROOT and $GOBIN in script output

They were necessary to produce a canonical script
when we checked in build scripts, but now they're just
getting in the way.

Fixes issue 3279.

[rsc, 2012-03-12 16:22:01]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-03-12 16:24:14]

LGTM

On Mon, Mar 12, 2012 at 9:22 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/go: stop using $GOROOT and $GOBIN in script output
>
> They were necessary to produce a canonical script
> when we checked in build scripts, but now they're just
> getting in the way.
>
> Fixes issue 3279.
>
> Please review this at
http://codereview.appspot.com/**5796068/<http://codereview.appspot.com/5796068/>
>
> Affected files:
>  M src/cmd/go/build.go
>
>
> Index: src/cmd/go/build.go
> ==============================**==============================**=======
> --- a/src/cmd/go/build.go
> +++ b/src/cmd/go/build.go
> @@ -929,8 +929,6 @@
>        if b.work != "" {
>                cmd = strings.Replace(cmd, b.work, "$WORK", -1)
>        }
> -       cmd = strings.Replace(cmd, gobin, "$GOBIN", -1)
> -       cmd = strings.Replace(cmd, goroot, "$GOROOT", -1)
>        return cmd
>  }
>
>
>
>

[rsc, 2012-03-12 16:39:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=ee6ef7631ce4 ***

cmd/go: stop using $GOROOT and $GOBIN in script output

They were necessary to produce a canonical script
when we checked in build scripts, but now they're just
getting in the way.

Fixes issue 3279.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5796068