code review 5758069: encoding/gob: fix memory corruption

encoding/gob: fix memory corruption
Fixes issue 3175.

[dvyukov, 2012-03-07 15:03:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[iant, 2012-03-07 15:24:02]

http://codereview.appspot.com/5758069/diff/7001/src/pkg/encoding/gob/gobencde...
File src/pkg/encoding/gob/gobencdec_test.go (right):

http://codereview.appspot.com/5758069/diff/7001/src/pkg/encoding/gob/gobencde...
src/pkg/encoding/gob/gobencdec_test.go:592: t.Fatalf("expected nil, got %v",
err)
s/err/err2/

[dvyukov, 2012-03-07 15:25:59]

Hello golang-dev@googlegroups.com, iant@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[iant, 2012-03-07 15:27:41]

LGTM but r should check it.

[rsc, 2012-03-07 15:29:49]

Leaving for r.

It matches the surrounding code, so I do think
it's correct; thanks very much for finding this.

[r, 2012-03-07 21:48:58]

LGTM
sorry

[r, 2012-03-07 21:53:15]

*** Submitted as http://code.google.com/p/go/source/detail?r=030cdbccb2e1 ***

encoding/gob: fix memory corruption
Fixes issue 3175.

R=golang-dev, iant, rsc, r
CC=golang-dev
http://codereview.appspot.com/5758069

Committer: Rob Pike <r@golang.org>