code review 5707056: net/http: make a test more paranoid & reliable on Windo...

net/http: make a test more paranoid & reliable on Windows, maybe.

Part of diagnosing issue 3050.

[bradfitz, 2012-02-29 02:04:48]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-02-29 02:07:03]

FWIW, this should have no effect.

But who knows.


On Tue, Feb 28, 2012 at 6:04 PM, <bradfitz@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net/http: make a test more paranoid & reliable on Windows, maybe.
>
> Part of diagnosing issue 3050.
>
> Please review this at
http://codereview.appspot.com/**5707056/<http://codereview.appspot.com/5707056/>
>
> Affected files:
>  M src/pkg/net/http/fs_test.go
>
>
> Index: src/pkg/net/http/fs_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/fs_test.go
> +++ b/src/pkg/net/http/fs_test.go
> @@ -152,12 +152,19 @@
>        }
>  }
>
> +func mustRemoveAll(dir string) {
> +       err := os.RemoveAll(dir)
> +       if err != nil {
> +               panic(err)
> +       }
> +}
> +
>  func TestFileServerImplicitLeadingS**lash(t *testing.T) {
>        tempDir, err := ioutil.TempDir("", "")
>        if err != nil {
>                t.Fatalf("TempDir: %v", err)
>        }
> -       defer os.RemoveAll(tempDir)
> +       defer mustRemoveAll(tempDir)
>        if err := ioutil.WriteFile(filepath.**Join(tempDir, "foo.txt"),
> []byte("Hello world"), 0644); err != nil {
>                t.Fatalf("WriteFile: %v", err)
>        }
> @@ -172,6 +179,7 @@
>                if err != nil {
>                        t.Fatalf("ReadAll %s: %v", suffix, err)
>                }
> +               res.Body.Close()
>                return string(b)
>        }
>        if s := get("/bar/"); !strings.Contains(s, ">foo.txt<") {
>
>
>

[rsc, 2012-02-29 16:28:58]

LGTM

[bradfitz, 2012-02-29 17:53:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=42ff329df337 ***

net/http: make a test more paranoid & reliable on Windows, maybe.

Part of diagnosing issue 3050.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5707056