Issue 5689065: runtime: initialize TLS before thr_new on FreeBSD/amd64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5689065: runtime: initialize TLS before thr_new on FreeBSD/amd64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by minux1

Modified:
12 years, 2 months ago

Reviewers:
rsc, mikio, adg, dho, golang-dev

CC:
golang-dev

Visibility:
Public.

Description

runtime: initialize TLS before thr_new on FreeBSD/amd64 If not, and a signal arrive just before runtime.thr_start could setup the TLS for m and g, the signal handler will trigger a SIGSEGV, which will in turn trigger yet another SIGSEGV, but this time, SIGSEGV is blocked, so a core dump results. Fixes issue 3017.

Patch Set 1 #

Patch Set 2 : diff -r a194c22248eb https://code.google.com/p/go/ #

Patch Set 3 : diff -r 767b6229d4dc https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -14 lines)			Patch
	M	src/pkg/runtime/sys_freebsd_amd64.s	View	1 2	1 chunk	+0 lines, -12 lines	0 comments	Download
	M	src/pkg/runtime/thread_freebsd.c	View	1 2	1 chunk	+10 lines, -2 lines	0 comments	Download