code review 5675053: bytes,strings: make *Reader implement io.ReaderAt

bytes,strings: make *Reader implement io.ReaderAt

[bradfitz, 2012-02-15 00:40:45]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2012-02-15 00:45:11]

LGTM

http://codereview.appspot.com/5675053/diff/1016/src/pkg/bytes/reader_test.go
File src/pkg/bytes/reader_test.go (right):

http://codereview.appspot.com/5675053/diff/1016/src/pkg/bytes/reader_test.go#...
src/pkg/bytes/reader_test.go:15: // Statically verify that *Reader implements
all the interfaces
I'd put this next to the doc comment so it's easier to keep them in sync (not
that it wil change much, I guess).

I don't think this generates any code, so there's no real advantage to putting
this in the test.

[adg, 2012-02-15 00:45:58]

What about mime/multipart/formdata.go?

[bradfitzgoog, 2012-02-15 00:48:23]

http://codereview.appspot.com/5675053/diff/1016/src/pkg/bytes/reader_test.go
File src/pkg/bytes/reader_test.go (right):

http://codereview.appspot.com/5675053/diff/1016/src/pkg/bytes/reader_test.go#...
src/pkg/bytes/reader_test.go:15: // Statically verify that *Reader implements
all the interfaces
On 2012/02/15 00:45:11, adg wrote:
> I'd put this next to the doc comment so it's easier to keep them in sync (not
> that it wil change much, I guess).
> 
> I don't think this generates any code, so there's no real advantage to putting
> this in the test.

I've heard objections.  It's a slippery slope that leads to Java & people
thinking they have to write those lines.

I actually half expect it be proposed that I delete these, even in _test.go. 
But at least here people can't easily see these on golang.org when clicking
through to the source code, learning bad practices.

[bradfitz, 2012-02-15 00:49:51]

Hello golang-dev@googlegroups.com, adg@golang.org, bradfitz@google.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-02-15 00:49:58]

On Wed, Feb 15, 2012 at 11:45 AM, <adg@golang.org> wrote:

> What about mime/multipart/formdata.go?
>

Added.

Anything else?

[adg, 2012-02-15 00:51:44]

On 15 February 2012 11:49, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> On Wed, Feb 15, 2012 at 11:45 AM, <adg@golang.org> wrote:
>>
>> What about mime/multipart/formdata.go?
>
>
> Added.
>
> Anything else?

A pony. And find me a date.

LGTM - I'll defer to the wisdom of others on the question of interface
satisfaction.

[r, 2012-02-15 01:50:07]

http://codereview.appspot.com/5675053/diff/3004/src/pkg/bytes/reader_test.go
File src/pkg/bytes/reader_test.go (right):

http://codereview.appspot.com/5675053/diff/3004/src/pkg/bytes/reader_test.go#...
src/pkg/bytes/reader_test.go:23: )
delete these. they encourage javathink

http://codereview.appspot.com/5675053/diff/3004/src/pkg/strings/reader_test.go
File src/pkg/strings/reader_test.go (right):

http://codereview.appspot.com/5675053/diff/3004/src/pkg/strings/reader_test.g...
src/pkg/strings/reader_test.go:23: )
delete

[bradfitz, 2012-02-15 01:58:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=8669402dfd95 ***

bytes,strings: make *Reader implement io.ReaderAt

R=golang-dev, adg, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/5675053