Issue 5674060: code review 5674060: bufio: don't return errors from good Peeks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5674060: code review 5674060: bufio: don't return errors from good Peeks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by bradfitz

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

bufio: don't return errors from good Peeks Fixes issue 3022

Patch Set 2 : diff -r bf1ad757aa33 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bf1ad757aa33 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r bf1ad757aa33 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r e9d84fc1c41a https://go.googlecode.com/hg/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
	M	src/pkg/bufio/bufio.go	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
	M	src/pkg/bufio/bufio_test.go	View	1 2 3 4	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2012-02-15 22:37:19 UTC) #1

http://codereview.appspot.com/5674060/diff/2004/src/pkg/bufio/bufio_test.go File src/pkg/bufio/bufio_test.go (right): http://codereview.appspot.com/5674060/diff/2004/src/pkg/bufio/bufio_test.go#newcode547 src/pkg/bufio/bufio_test.go:547: } you need to test: peek you get no ...

12 years, 3 months ago (2012-02-15 23:01:39 UTC) #2

bradfitz

Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 3 months ago (2012-02-15 23:06:28 UTC) #3

LGTM http://codereview.appspot.com/5674060/diff/4002/src/pkg/bufio/bufio_test.go File src/pkg/bufio/bufio_test.go (right): http://codereview.appspot.com/5674060/diff/4002/src/pkg/bufio/bufio_test.go#newcode557 src/pkg/bufio/bufio_test.go:557: d

12 years, 3 months ago (2012-02-15 23:10:56 UTC) #4

bradfitz

12 years, 3 months ago (2012-02-15 23:15:43 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=e3d26a0ced74 ***

bufio: don't return errors from good Peeks

Fixes issue 3022

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5674060

Expand All Messages | Collapse All Messages