Issue 5674048: code review 5674048: cmd/go: go test -i correctly handle cgo packages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5674048: code review 5674048: cmd/go: go test -i correctly handle cgo packages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by minux1

Modified:
12 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/go: go test -i correctly handle cgo packages Previous CL (5674043) omit the case where runtime/cgo itself is out-of-date. Fixes issue 2936 (again).

Patch Set 2 : diff -r 348bbad57cab https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 04a64046570e https://go.googlecode.com/hg/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/cmd/go/test.go	View	1 2	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

minux1

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2012-02-15 03:36:56 UTC) #1

minux1

I wonder whether "cmd/cgo" should be included in test prerequisite too.

12 years, 3 months ago (2012-02-15 03:38:31 UTC) #2

rsc

http://codereview.appspot.com/5674048/diff/1002/src/cmd/go/test.go File src/cmd/go/test.go (right): http://codereview.appspot.com/5674048/diff/1002/src/cmd/go/test.go#newcode279 src/cmd/go/test.go:279: deps["runtime/cgo"] = true If buildContext.GOOS == runtime.GOOS && buildContext.GOARCH ...

12 years, 3 months ago (2012-02-15 14:21:09 UTC) #3

minux1

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 3 months ago (2012-02-15 15:49:27 UTC) #4

rsc

12 years, 3 months ago (2012-02-15 18:26:27 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=e85f8a507c4d ***

cmd/go: go test -i correctly handle cgo packages
Previous CL (5674043) omit the case where runtime/cgo itself is out-of-date.
Fixes issue 2936 (again).

R=rsc
CC=golang-dev
http://codereview.appspot.com/5674048

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages