Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(715)

Issue 5673076: code review 5673076: net: package doc overview / examples (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by bradfitz
Modified:
12 years, 2 months ago
Reviewers:
rsc
CC:
golang-dev, r
Visibility:
Public.

Description

net: package doc overview / examples Fixes issue 2774

Patch Set 1 #

Patch Set 2 : diff -r 4b3cca9c3331 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4b3cca9c3331 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 4b3cca9c3331 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 86464104e425 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M src/pkg/net/net.go View 1 2 3 4 1 chunk +33 lines, -2 lines 0 comments Download

Messages

Total messages: 6
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 2 months ago (2012-02-17 00:47:57 UTC) #1
r
http://codereview.appspot.com/5673076/diff/5001/src/pkg/net/net.go File src/pkg/net/net.go (right): http://codereview.appspot.com/5673076/diff/5001/src/pkg/net/net.go#newcode6 src/pkg/net/net.go:6: Package net provides a portable interface to Unix networks ...
12 years, 2 months ago (2012-02-17 00:56:21 UTC) #2
bradfitz
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 2 months ago (2012-02-17 01:51:15 UTC) #3
r
LGTM (but make sure the example compiles and runs, just in case)
12 years, 2 months ago (2012-02-17 01:53:28 UTC) #4
bradfitz
*** Submitted as http://code.google.com/p/go/source/detail?r=0effb05ba6ea *** net: package doc overview / examples Fixes issue 2774 R=golang-dev, ...
12 years, 2 months ago (2012-02-17 02:07:12 UTC) #5
rsc
12 years, 2 months ago (2012-02-17 02:57:02 UTC) #6
It would be nice for this comment to mention the
generic types Conn and Listener too and say that while
specific concrete implementations exist, most code
should use the general ones.  Also it might be worth
noting that other packages and do implement
these interfaces too.  In particular crypto/tls provides
the same kind of API and the same exact interfaces
with its Dial and Listen.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b