Issue 5652074: code review 5652074: cmd/go: Add support for passing custom link flags.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5652074: code review 5652074: cmd/go: Add support for passing custom link flags. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by cookieo9

Modified:
12 years, 2 months ago

Reviewers:
golang-dev

CC:
golang-dev

Visibility:
Public.

Description

cmd/go: Add support for passing custom link flags. Makes cmd/go check the environment variable GLDFLAGS for extra option to pass to the linker (8l, 6l, or 5l) in the link step of go build, go install, etc... The enviroment variable was chosen to be analagous to the existing GCFLAGS variable for passing compiler variables to 8g, 6g, or 5g. Fixes issue 2996.

Patch Set 1 #

Patch Set 2 : diff -r 637fa427fef5 https://code.google.com/p/go #

Patch Set 3 : diff -r 5d4cd2971008 https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/cmd/go/build.go	View	1	3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

cookieo9

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2012-02-12 04:59:45 UTC) #1

*** Abandoned ***

Expand All Messages | Collapse All Messages