Issue 5645080: code review 5645080: go/printer: test that formatted code is parseable

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5645080: code review 5645080: go/printer: test that formatted code is parseable (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by gri

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

go/printer: test that formatted code is parseable - Added test case for issue 1542. Fixes issue 1542.

Patch Set 1 #

Patch Set 2 : diff -r caf7dca9d711 https://code.google.com/p/go #

Patch Set 3 : diff -r caf7dca9d711 https://code.google.com/p/go #

Patch Set 4 : diff -r 507582df4ca6 https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -2 lines)			Patch
M	src/pkg/go/printer/printer_test.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments.golden	View	1	2 chunks	+21 lines, -1 line	0 comments	Download
M	src/pkg/go/printer/testdata/comments.input	View	1	2 chunks	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2012-02-10 19:59:20 UTC) #1

gri

12 years, 3 months ago (2012-02-10 21:28:31 UTC) #3

*** Submitted as 3355c593acd8 ***

go/printer: test that formatted code is parseable

- Added test case for issue 1542.

Fixes issue 1542.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5645080

Expand All Messages | Collapse All Messages