code review 5639068: strings: add Seek method to Reader

strings: add Seek method to Reader

strings.Reader is already stateful and read-only.

This permits a *Reader with http.ServeContent.

[bradfitz, 2012-02-09 04:16:39]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-02-09 04:54:19]

i'd rather not, but am willing to hear what others think.

the new dependency bothers me although, i am amazed to report, it does not
introduce a loop

http://codereview.appspot.com/5639068/diff/5001/src/pkg/strings/reader.go
File src/pkg/strings/reader.go (right):

http://codereview.appspot.com/5639068/diff/5001/src/pkg/strings/reader.go#new...
src/pkg/strings/reader.go:10: "os"
new dependency i don't like

http://codereview.appspot.com/5639068/diff/5001/src/pkg/strings/reader.go#new...
src/pkg/strings/reader.go:14: var _ io.ReadSeeker = (*Reader)(nil)
if you're going to check this, check the others too.

http://codereview.appspot.com/5639068/diff/5001/src/pkg/strings/reader.go#new...
src/pkg/strings/reader.go:107: return 0, errors.New("strings: invalid whence")
the errors could say strings.Seek

[rsc, 2012-02-09 04:59:33]

I'm fine with adding Seek.  (See also issue 2681, for after Go 1.)
Please do not import "os".  Package io defines the
arguments: 0, 1, 2, beginning, middle, end.

Please delete the var _ stuff.  I don't want to litter the core
libraries with those.  It will turn into Java.

Russ

[bradfitz, 2012-02-09 05:19:47]

Hello golang-dev@googlegroups.com, r@golang.org, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2012-02-09 05:25:17]

LGTM but wait for r

[r, 2012-02-09 05:56:26]

add a test

[bradfitz, 2012-02-09 06:13:38]

Hello golang-dev@googlegroups.com, r@golang.org, rsc@golang.org, rsc@google.com
(cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-02-09 06:15:21]

done

On Wed, Feb 8, 2012 at 9:56 PM, <r@golang.org> wrote:

> add a test
>
>
http://codereview.appspot.com/**5639068/<http://codereview.appspot.com/5639068/>
>

[r, 2012-02-09 06:17:38]

LGTM

[bradfitz, 2012-02-09 06:28:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=e86e50000118 ***

strings: add Seek method to Reader

strings.Reader is already stateful and read-only.

This permits a *Reader with http.ServeContent.

R=golang-dev, r, rsc, rsc
CC=golang-dev
http://codereview.appspot.com/5639068