Issue 5627045: code review 5627045: openpgp/packet: move OCFB code here.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5627045: code review 5627045: openpgp/packet: move OCFB code here. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by agl1

Modified:
12 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

openpgp/packet: move OCFB code here. The code has been moved from crypto/cipher in CL 5629044.

Patch Set 1 #

Patch Set 2 : diff -r b5c95223a8c6 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r b5c95223a8c6 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r b5c95223a8c6 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r b5c95223a8c6 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -4 lines)			Patch
A	openpgp/packet/ocfb.go	View	1	1 chunk	+143 lines, -0 lines	0 comments	Download
A	openpgp/packet/ocfb_test.go	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download
M	openpgp/packet/symmetrically_encrypted.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://agl%40golang.org@code.google.com/p/go.crypto/

12 years, 2 months ago (2012-02-03 19:25:32 UTC) #1

agl1

12 years, 2 months ago (2012-02-03 20:08:16 UTC) #3

*** Submitted as 879260e22e51 ***

openpgp/packet: move OCFB code here.

The code has been moved from crypto/cipher in CL 5629044.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5627045

Expand All Messages | Collapse All Messages