code review 5604048: cmd/go: improvements

cmd/go: improvements

Print all the syntax errors.  Fixes issue 2811.

Change Windows binary removal strategy.
This should keep the temporary files closer to
the binaries they are for, which will make it
more likely that the rename is not cross-device
and also make it easier to clean them up.
Fixes issue 2604 (as much as we can).

The standard build does not use the go command
to install the go command anymore, so issue 2604
is less of a concern than it originally was.
(It uses the go_bootstrap command to install
the go command.)

Buffer 'go list' output.

[rsc, 2012-01-31 23:17:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-01-31 23:21:19]

http://codereview.appspot.com/5604048/diff/1003/src/cmd/go/build.go
File src/cmd/go/build.go (right):

http://codereview.appspot.com/5604048/diff/1003/src/cmd/go/build.go#newcode720
src/cmd/go/build.go:720: if _, err := os.Stat(dst + "~"); err != nil {
err == nil, right?

http://codereview.appspot.com/5604048/diff/1003/src/cmd/go/build.go#newcode733
src/cmd/go/build.go:733: os.Remove(dst + "~")
if previous line == nil ?

[rsc, 2012-01-31 23:39:27]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-01-31 23:39:55]

LGTM after bradfitz's comments

[rsc, 2012-01-31 23:44:23]

*** Submitted as http://code.google.com/p/go/source/detail?r=64f5d54408cc ***

cmd/go: improvements

Print all the syntax errors.  Fixes issue 2811.

Change Windows binary removal strategy.
This should keep the temporary files closer to
the binaries they are for, which will make it
more likely that the rename is not cross-device
and also make it easier to clean them up.
Fixes issue 2604 (as much as we can).

The standard build does not use the go command
to install the go command anymore, so issue 2604
is less of a concern than it originally was.
(It uses the go_bootstrap command to install
the go command.)

Buffer 'go list' output.

R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/5604048