code review 5580044: net/http: add Request.RequestURI field

net/http: add Request.RequestURI field

The new url.URL's parsing can be too canonicalizing for
certain applications. By keeping the original request URI
around, we give applications a gross escape hatch while
keeping the URL package clean and simple for normal uses.

(From a discussion with Gary Burd, Gustavo Niemeyer,
and Russ Cox.)

Fixes issue 2782

[bradfitz, 2012-01-26 21:56:28]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[rsc, 2012-01-26 22:03:32]

LGTM but s/RawRequestURI/RequestURI/

RequestURI is by definition raw; see also the method on URL.

Fixes issue 2782.

[bradfitz, 2012-01-26 22:26:30]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-01-26 22:28:04]

PTAL

It's now documented & enforced to be an error to set this in client
requests.

Clients can use Request.URL.Opaque if they really must do something gross
(even though that's kinda an abuse).  We might allow Request.RequestURL in
the future so explicitly disallow it now so we reserve that possibility
without breaking code or having to document precedence rules.


On Thu, Jan 26, 2012 at 2:26 PM, <bradfitz@golang.org> wrote:

> Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**5580044/<http://codereview.appspot.com/5580044/>
>

[dsymonds, 2012-01-26 22:29:42]

LGTM

[bradfitz, 2012-01-26 22:37:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=e7ec3472dc79 ***

net/http: add Request.RequestURI field

The new url.URL's parsing can be too canonicalizing for
certain applications. By keeping the original request URI
around, we give applications a gross escape hatch while
keeping the URL package clean and simple for normal uses.

(From a discussion with Gary Burd, Gustavo Niemeyer,
and Russ Cox.)

Fixes issue 2782

R=golang-dev, rsc, dsymonds
CC=golang-dev
http://codereview.appspot.com/5580044