code review 5574078: os: remove SIGXXX signals variables.

os: remove SIGXXX signals variables.

They're not portable, and pkg os is supposed to be portable.

Fixes issue 2562

[bradfitz, 2012-01-27 01:33:44]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2012-01-27 03:09:35]

LGTM

I guess src/buildscript files will come after as another CL 
which contains super duper big chunks.

[r2, 2012-01-27 05:07:48]

This is probably OK, although it might break a few programs. I'd like to hear
from the others.

-rob

[bradfitz, 2012-01-27 17:24:31]

Hello golang-dev@googlegroups.com, mikioh.mikioh@gmail.com, r@google.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-01-27 17:25:21]

(added the buildscripts to this CL too)

On Fri, Jan 27, 2012 at 9:24 AM, <bradfitz@golang.org> wrote:

> Hello golang-dev@googlegroups.com, mikioh.mikioh@gmail.com, r@google.com
> (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**5574078/<http://codereview.appspot.com/5574078/>
>

[niemeyer, 2012-01-27 17:32:25]

I suspect more will have to change if that's to be cleaned up. For example,
exec_windows.go seems to reference SIGKILL too, and I'm not sure if it makes
sense to have UnixSignal if we're removing the signals.

[rsc, 2012-01-27 22:34:53]

LGTM

We can leave UnixSignal for now.
Maybe it will move to os/signal once that package
has no side effects on import.

[bradfitz, 2012-01-27 22:47:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=8179934cf77e ***

os: remove SIGXXX signals variables.

They're not portable, and pkg os is supposed to be portable.

Fixes issue 2562

R=golang-dev, mikioh.mikioh, r, n13m3y3r, rsc
CC=golang-dev
http://codereview.appspot.com/5574078