Issue 5573076: compress/flate: reduce GC pressure from huffmanEncoder....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5573076: compress/flate: reduce GC pressure from huffmanEncoder.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Ivan Krasin

Modified:
10 years, 11 months ago

Reviewers:
imkrasin, dave, remyoudompheng

CC:
golang-dev

Visibility:
Public.

Description

compress/flate: reduce GC pressure from huffmanEncoder.bitCounts.

Patch Set 1 : diff -r 7151ff594254 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -70 lines)			Patch
	M	src/pkg/compress/flate/huffman_code.go	View		8 chunks	+42 lines, -70 lines	1 comment	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

remyoudompheng

ping I like this change as it would clean up my allocation profiles :)

11 years, 7 months ago (2012-10-06 15:18:36 UTC) #1

imkrasin

On 2012/10/06 15:18:36, remyoudompheng wrote: > ping > > I like this change as it ...

11 years, 7 months ago (2012-10-11 09:39:37 UTC) #2

imkrasin

On 2013/04/25 00:48:18, dfc wrote: > ping. pong. Dave, I promise to rebase this CL ...

11 years ago (2013-04-25 01:00:04 UTC) #4

imkrasin

https://codereview.appspot.com/5573076/diff/3/src/pkg/compress/flate/huffman_code.go File src/pkg/compress/flate/huffman_code.go (right): https://codereview.appspot.com/5573076/diff/3/src/pkg/compress/flate/huffman_code.go#newcode160 src/pkg/compress/flate/huffman_code.go:160: var chains [4096]chain heh. I don't even remember why ...

11 years ago (2013-04-27 21:16:39 UTC) #5

imkrasin

10 years, 11 months ago (2013-05-21 01:49:15 UTC) #7

On 2013/05/21 00:07:04, remyoudompheng wrote:
> ping?

I am sad to say that, but this CL needs to be recreated from scratch, as I have
completely forgot the underlying wisdom.

I could not promise that I will do it anytime soon. Sorry about that.

Expand All Messages | Collapse All Messages