Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(986)

Issue 5523047: code review 5523047: gc: fix infinite recursion for embedded interfaces (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by lvd
Modified:
12 years, 2 months ago
Reviewers:
albert.strasheim
CC:
rsc, gri, golang-dev
Visibility:
Public.

Description

gc: fix infinite recursion for embedded interfaces Fixes issue 1909

Patch Set 1 #

Patch Set 2 : diff -r fa49a85c5941 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 07184a938f08 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8c6f3122826c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8c6f3122826c https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r cf2fb43dedaa https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r cf2fb43dedaa https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 1000b88c19e2 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 9 : diff -r 4f026dec52ea https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -21 lines) Patch
M src/cmd/gc/dcl.c View 1 2 3 2 chunks +11 lines, -2 lines 0 comments Download
M src/cmd/gc/export.c View 1 2 3 4 2 chunks +9 lines, -2 lines 0 comments Download
M src/cmd/gc/fmt.c View 1 2 3 4 5 6 7 8 8 chunks +16 lines, -2 lines 0 comments Download
M src/cmd/gc/go.y View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -1 line 0 comments Download
M src/pkg/exp/types/gcimporter.go View 1 2 3 4 5 6 7 8 1 chunk +17 lines, -14 lines 0 comments Download
A test/fixedbugs/bug395.go View 1 2 3 4 5 6 7 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11
lvd
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 2 months ago (2012-01-12 09:40:04 UTC) #1
lvd
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 2 months ago (2012-01-12 21:39:45 UTC) #2
rsc
what's here lgtm
12 years, 2 months ago (2012-01-12 21:42:02 UTC) #3
lvd
merci. then i'll go fix gcimporter again. On Thu, Jan 12, 2012 at 22:42, Russ ...
12 years, 2 months ago (2012-01-12 21:45:29 UTC) #4
lvd
Hello rsc@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 2 months ago (2012-01-16 10:57:43 UTC) #5
lvd
Added gri for the changes to gcimporter. Again, minimal changes to keep it parsing, but ...
12 years, 2 months ago (2012-01-16 10:58:41 UTC) #6
gri
FYI. Otherwise the gcimporter changes LGTM. - gri http://codereview.appspot.com/5523047/diff/13002/src/pkg/exp/types/gcimporter.go File src/pkg/exp/types/gcimporter.go (right): http://codereview.appspot.com/5523047/diff/13002/src/pkg/exp/types/gcimporter.go#newcode463 src/pkg/exp/types/gcimporter.go:463: // ...
12 years, 2 months ago (2012-01-16 18:57:26 UTC) #7
rsc
LGTM
12 years, 2 months ago (2012-01-17 00:01:59 UTC) #8
lvd
http://codereview.appspot.com/5523047/diff/13002/src/pkg/exp/types/gcimporter.go File src/pkg/exp/types/gcimporter.go (right): http://codereview.appspot.com/5523047/diff/13002/src/pkg/exp/types/gcimporter.go#newcode463 src/pkg/exp/types/gcimporter.go:463: // MethodOrEmbedSpec = MethodSpec | EmbedSpec . On 2012/01/16 ...
12 years, 2 months ago (2012-01-17 09:00:28 UTC) #9
lvd
*** Submitted as http://code.google.com/p/go/source/detail?r=f1deaf35e1d1 *** gc: fix infinite recursion for embedded interfaces Fixes issue 1909 ...
12 years, 2 months ago (2012-01-17 09:01:01 UTC) #10
albert.strasheim
12 years, 2 months ago (2012-01-19 15:15:10 UTC) #11
On 2012/01/17 09:01:01, lvd wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=f1deaf35e1d1 ***
> gc: fix infinite recursion for embedded interfaces
> Fixes issue 1909
> R=rsc, gri
> CC=golang-dev
> http://codereview.appspot.com/5523047

I think we've picked up a problem with this change.

http://code.google.com/p/go/issues/detail?id=2741
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b