code review 5495049: go/scanner: strip CRs from raw literals

go/scanner: strip CRs from raw literals

[gri, 2011-12-15 17:19:58]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-12-15 17:22:50]

If the caller passed a []byte when creating the
scanner, does this edit the contents of that []byte?
If so, call stripCR on a copy?

[gri, 2011-12-15 17:35:12]

good point
PTAL
(In retrospect, trying to be fast and returning the literals from the
src buffer directly made things more complicated. The scanner should
just take a reader and assemble literals as needed - a TODO).

On Thu, Dec 15, 2011 at 9:22 AM, Russ Cox <rsc@golang.org> wrote:
> If the caller passed a []byte when creating the
> scanner, does this edit the contents of that []byte?
> If so, call stripCR on a copy?

[rsc, 2011-12-15 18:29:33]

LGTM

[gri, 2011-12-15 18:51:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=378b1f8ca33b ***

go/scanner: strip CRs from raw literals

R=rsc
CC=golang-dev
http://codereview.appspot.com/5495049