code review 4672056: gob: register more slice types

gob: register more slice types

Without explicitly registering slice types, gob fails to encode
map[string]interface{} instances where the value is a slice,
failing with a message such as:

  gob: type not registered for interface: []string

Fixes issue 2065.

[gri, 2011-07-13 01:41:42]

The CL description should say, just so:

Fixes issue 2065.

Otherwise this looks reasonable to me. Perhaps there should be a more
comprehensive test?

Leaving for r.

[bpowers, 2011-07-13 05:40:06]

Hello golang-dev@googlegroups.com, gri@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bpowers, 2011-07-13 05:42:50]

Hi folks,

I've updated the CL description and expanded the test to test for more slice
types.

PTAL.

yours,
Bobby

[r, 2011-07-13 06:00:46]

http://codereview.appspot.com/4672056/diff/5001/src/pkg/gob/encoder_test.go
File src/pkg/gob/encoder_test.go (right):

http://codereview.appspot.com/4672056/diff/5001/src/pkg/gob/encoder_test.go#n...
src/pkg/gob/encoder_test.go:568: "c1": []complex128{complex(2, float64(-2))},
uintptr and bool here too

http://codereview.appspot.com/4672056/diff/5001/src/pkg/gob/type.go
File src/pkg/gob/type.go (right):

http://codereview.appspot.com/4672056/diff/5001/src/pkg/gob/type.go#newcode777
src/pkg/gob/type.go:777: Register([]uint64(nil))
uintptr, everyone forgets uintptr
and many forget bool.

[bpowers, 2011-07-13 06:38:13]

Hello golang-dev@googlegroups.com, gri@golang.org, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2011-07-13 07:11:29]

LGTM

[r, 2011-07-13 07:12:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=7f39a0541e03 ***

gob: register more slice types

Without explicitly registering slice types, gob fails to encode
map[string]interface{} instances where the value is a slice,
failing with a message such as:

  gob: type not registered for interface: []string

Fixes issue 2065.

R=golang-dev, gri, r
CC=golang-dev
http://codereview.appspot.com/4672056

Committer: Rob Pike <r@golang.org>