Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 4532089: code review 4532089: mime/multipart: misc code/doc fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by bradfitz
Modified:
12 years, 11 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

mime/multipart: misc code/doc fixes

Patch Set 1 #

Patch Set 2 : diff -r 96fb12b2040e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 96fb12b2040e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 96fb12b2040e https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 96fb12b2040e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M src/pkg/mime/multipart/writer.go View 1 2 3 5 chunks +33 lines, -40 lines 0 comments Download
M src/pkg/mime/multipart/writer_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
bradfitz
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 11 months ago (2011-05-25 23:40:33 UTC) #1
rsc
LGTM would like to see Closer drop too but that can be another CL if ...
12 years, 11 months ago (2011-05-25 23:59:58 UTC) #2
bradfitz
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 11 months ago (2011-05-26 00:10:06 UTC) #3
bradfitz
Kept internal paranoia & error messages but removed Closer from public API & docs. Also ...
12 years, 11 months ago (2011-05-26 00:13:13 UTC) #4
rsc
LGTM
12 years, 11 months ago (2011-05-26 02:11:46 UTC) #5
bradfitz
12 years, 11 months ago (2011-05-26 02:21:11 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=22e8eec48b9f ***

mime/multipart: misc code/doc fixes

R=rsc
CC=golang-dev
http://codereview.appspot.com/4532089
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b