Issue 4442086: code review 4442086: http: keep gzip reader inside eofsignaler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4442086: code review 4442086: http: keep gzip reader inside eofsignaler (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bradfitz

Modified:
13 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

http: keep gzip reader inside eofsignaler Fixes issue 1725

Patch Set 1 #

Patch Set 2 : diff -r 3211aa1f1e32 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3211aa1f1e32 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 093debaa3f04 https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -54 lines)			Patch
M	src/pkg/http/response_test.go	View	1	2 chunks	+71 lines, -33 lines	0 comments	Download
M	src/pkg/http/transport.go	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/pkg/http/transport_test.go	View	1 2	2 chunks	+70 lines, -19 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2011-04-27 20:53:34 UTC) #1

bradfitz

Despite all the new tests, none of them actually catch the bug. If I remove ...

13 years ago (2011-04-27 20:57:02 UTC) #2

bradfitz

13 years ago (2011-04-27 21:23:27 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=22fa8d29da35 ***

http: keep gzip reader inside eofsignaler

Fixes issue 1725

R=rsc
CC=golang-dev
http://codereview.appspot.com/4442086

Expand All Messages | Collapse All Messages