Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(207)

Issue 4343056: code review 4343056: net: disable multicast tests by default. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by dfc
Modified:
12 years, 11 months ago
Reviewers:
CC:
rsc, adg, golang-dev
Visibility:
Public.

Description

net: disable multicast tests by default. Fixes issue 1649.

Patch Set 1 #

Patch Set 2 : diff -r dc1d5042801a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r dc1d5042801a https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 872404d61597 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/pkg/net/multicast_test.go View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8
dfc
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 12 months ago (2011-04-05 03:25:13 UTC) #1
dfc
PTAL
12 years, 11 months ago (2011-04-08 03:36:59 UTC) #2
adg
Why not use the -short flag instead? On 8 April 2011 13:36, <dave@cheney.net> wrote: > ...
12 years, 11 months ago (2011-04-08 05:30:36 UTC) #3
dfc
I based this CL on the IPV6 checks in pkg/net as it would appear to ...
12 years, 11 months ago (2011-04-08 06:38:21 UTC) #4
adg
http://codereview.appspot.com/4343056/diff/3001/src/pkg/net/multicast_test.go File src/pkg/net/multicast_test.go (right): http://codereview.appspot.com/4343056/diff/3001/src/pkg/net/multicast_test.go#newcode13 src/pkg/net/multicast_test.go:13: var multicast = flag.Bool("multicast", false, "assume multicast is working ...
12 years, 11 months ago (2011-04-11 00:07:55 UTC) #5
dfc
PTAL. http://codereview.appspot.com/4343056/diff/3001/src/pkg/net/multicast_test.go File src/pkg/net/multicast_test.go (right): http://codereview.appspot.com/4343056/diff/3001/src/pkg/net/multicast_test.go#newcode13 src/pkg/net/multicast_test.go:13: var multicast = flag.Bool("multicast", false, "assume multicast is ...
12 years, 11 months ago (2011-04-11 00:15:55 UTC) #6
adg
LGTM
12 years, 11 months ago (2011-04-11 00:34:44 UTC) #7
adg
12 years, 11 months ago (2011-04-11 00:39:29 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=4c6db3d9a715 ***

net: disable multicast tests by default.

Fixes issue 1649.

R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/4343056

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b