Issue 3766042: code review 3766042: net, syscall: Fixed Recvmsg to return source address.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3766042: code review 3766042: net, syscall: Fixed Recvmsg to return source address. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by albert.strasheim

Modified:
13 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

net, syscall: Fixed Recvmsg to return source address.

Patch Set 1 #

Patch Set 2 : code review 3766042: net, syscall: Fixed Recvmsg to return source address. #

Patch Set 3 : code review 3766042: net, syscall: Fixed Recvmsg to return source address. #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
M	src/pkg/net/fd.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_bsd.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_linux.go	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

albert.strasheim

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 5 months ago (2010-12-20 15:23:59 UTC) #1

albert.strasheim

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2011-01-04 09:18:39 UTC) #3

albert.strasheim

Ping? On 2011/01/04 09:18:39, albert.strasheim wrote: > Hello rsc (cc: mailto:golang-dev@googlegroups.com), > > Please take ...

13 years, 4 months ago (2011-01-18 04:58:30 UTC) #4

rsc

13 years, 4 months ago (2011-01-19 19:34:54 UTC) #6

*** Submitted as a47fe380e001 ***

net, syscall: return source address in Recvmsg

R=rsc
CC=golang-dev
http://codereview.appspot.com/3766042

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages