Issue 2353043: code review 2353043: net: allow _ in names

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2353043: code review 2353043: net: allow _ in names (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by rsc

Modified:
13 years, 6 months ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

net: allow _ in names Enables lookup of _jabber._tcp.gmail.com's SRV record. Fixes issue 1167.

Patch Set 1 #

Patch Set 2 : code review 2353043: net: allow _ in names #

Patch Set 3 : code review 2353043: net: allow _ in names #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/net/dnsclient.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 6 months ago (2010-10-07 09:14:41 UTC) #1

rsc

13 years, 6 months ago (2010-10-07 10:45:53 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=9b27e48edf12 ***

net: allow _ in names

Enables lookup of _jabber._tcp.gmail.com's SRV record.

Fixes issue 1167.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/2353043

Expand All Messages | Collapse All Messages