Issue 2216043: code review 2216043: Fix certificate validation.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2216043: code review 2216043: Fix certificate validation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by agl1

Modified:
13 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Fix certificate validation. asn1: add support for T61String because this is the string type which several www.google.com certificates are now using for fields like CommonName tls: force a handshake in Dial so that certificates are ready afterwards. Fixes issue 1114.

Patch Set 1 #

Total comments: 1

Patch Set 2 : code review 2216043: Fix certificate validation. #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -2 lines)			Patch
M	src/pkg/asn1/asn1.go	View		3 chunks	+12 lines, -0 lines	0 comments	Download
M	src/pkg/asn1/common.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/crypto/tls/conn.go	View		1 chunk	+9 lines, -1 line	0 comments	Download
M	src/pkg/crypto/tls/tls.go	View	1	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc1

LGTM http://codereview.appspot.com/2216043/diff/1/src/pkg/crypto/tls/tls.go File src/pkg/crypto/tls/tls.go (right): http://codereview.appspot.com/2216043/diff/1/src/pkg/crypto/tls/tls.go#newcode75 src/pkg/crypto/tls/tls.go:75: return nil, err before this c.Close() ?

13 years, 7 months ago (2010-09-17 16:01:50 UTC) #2

agl1

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 7 months ago (2010-09-20 14:32:06 UTC) #3

agl1

13 years, 7 months ago (2010-09-20 14:32:34 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=9aa405106046 ***

Fix certificate validation.

asn1: add support for T61String because this is the string type which
    several www.google.com certificates are now using for fields like
    CommonName
tls: force a handshake in Dial so that certificates are ready
    afterwards.

Fixes issue 1114.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2216043

Expand All Messages | Collapse All Messages