Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1481)

Issue 194121: code review 194121: Allow underscores in XML element names (except for firs... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by hoisie
Modified:
14 years, 1 month ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

Allow underscores in XML element names (except for leading characters) Fixes issue 569

Patch Set 1 #

Patch Set 2 : code review 194121: Allow underscores in XML element names (except for firs... #

Patch Set 3 : code review 194121: Allow underscores in XML element names (except for firs... #

Total comments: 2

Patch Set 4 : code review 194121: Allow underscores in XML element names (except for firs... #

Total comments: 1

Patch Set 5 : code review 194121: Allow underscores in XML element names (except for lead... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M src/pkg/xml/read.go View 1 2 3 4 1 chunk +8 lines, -2 lines 0 comments Download
M src/pkg/xml/xml_test.go View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9
hoisie
Hello rsc (cc: golang-dev@googlegroups.com, r), I'd like you to review this change.
14 years, 2 months ago (2010-01-28 03:14:43 UTC) #1
rsc
Why does the code work so hard to disallow leading underscores? Why not just change ...
14 years, 2 months ago (2010-01-28 03:21:01 UTC) #2
r
http://codereview.appspot.com/194121/diff/8/1005 File src/pkg/xml/read.go (right): http://codereview.appspot.com/194121/diff/8/1005#newcode164 src/pkg/xml/read.go:164: return name strings.Map can do the job just fine. ...
14 years, 2 months ago (2010-01-28 03:25:00 UTC) #3
r
http://codereview.appspot.com/194121/diff/8/1005 File src/pkg/xml/read.go (right): http://codereview.appspot.com/194121/diff/8/1005#newcode164 src/pkg/xml/read.go:164: return name actually you need to delete all leading ...
14 years, 2 months ago (2010-01-28 03:30:11 UTC) #4
hoisie
ok done, leading underscores are removed On 2010/01/28 03:30:11, r wrote: > http://codereview.appspot.com/194121/diff/8/1005 > File ...
14 years, 2 months ago (2010-01-28 04:57:34 UTC) #5
r
http://codereview.appspot.com/194121/diff/1010/12 File src/pkg/xml/read.go (right): http://codereview.appspot.com/194121/diff/1010/12#newcode154 src/pkg/xml/read.go:154: for i = 0; i < len(original); i++ { ...
14 years, 2 months ago (2010-01-28 05:02:14 UTC) #6
hoisie
ok done + added a comment On 2010/01/28 05:02:14, r wrote: > http://codereview.appspot.com/194121/diff/1010/12 > File ...
14 years, 2 months ago (2010-01-28 05:10:55 UTC) #7
r
LGTM
14 years, 2 months ago (2010-01-28 05:12:41 UTC) #8
r
14 years, 2 months ago (2010-01-28 05:13:26 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=52b6d624f245 ***

Allow underscores in XML element names (except for leading characters)

Fixes issue 569

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/194121

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b