Issue 181073: code review 181073: fix dumb bug: must write out default values inside arra...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 181073: code review 181073: fix dumb bug: must write out default values inside arra... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by r

Modified:
14 years, 4 months ago

Reviewers:

CC:
rsc, imkrasin, sonia, golang-dev

Visibility:
Public.

Description

fix dumb bug: must write out default values inside arrays and slices Fixes issue 459.

Patch Set 2 : code review 181073: fix dumb bug: must write out default values inside arra... #

Patch Set 3 : code review 181073: fix dumb bug: must write out default values inside arra... #

Total comments: 2

Patch Set 4 : code review 181073: fix dumb bug: must write out default values inside arra... #

Patch Set 5 : code review 181073: fix dumb bug: must write out default values inside arra... #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -19 lines)			Patch
	M	src/pkg/gob/encode.go	View	1 2 3	18 chunks	+25 lines, -19 lines	0 comments	Download
	M	src/pkg/gob/encoder_test.go	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

14 years, 4 months ago (2009-12-28 00:44:54 UTC) #1

imkrasin

http://codereview.appspot.com/181073/diff/1003/1004 File src/pkg/gob/encode.go (left): http://codereview.appspot.com/181073/diff/1003/1004#oldcode107 src/pkg/gob/encode.go:107: encodeUint(state, 1) Here is a small bug. It should ...

14 years, 4 months ago (2009-12-28 08:23:05 UTC) #2

imkrasin

On 2009/12/28 16:18:25, rsc wrote: > LGTM Russ, take a look at my comment. I'm ...

14 years, 4 months ago (2009-12-28 16:45:44 UTC) #4

sonia

Patch set 4 (with the bool fix) looks good to me, and fixes problem behavior ...

14 years, 4 months ago (2009-12-28 20:14:37 UTC) #5

14 years, 4 months ago (2009-12-28 20:41:59 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=44763425d6a5 ***

fix dumb bug: must write out default values inside arrays and slices

Fixes issue 459.

R=rsc, imkrasin, sonia
CC=golang-dev
http://codereview.appspot.com/181073

http://codereview.appspot.com/181073/diff/1003/1004
File src/pkg/gob/encode.go (left):

http://codereview.appspot.com/181073/diff/1003/1004#oldcode107
src/pkg/gob/encode.go:107: encodeUint(state, 1)
good catch

Expand All Messages | Collapse All Messages