Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(696)

Issue 165860043: code review 165860043: archive/tar: fix round-trip attributes

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by vbatts
Modified:
9 years, 4 months ago
Reviewers:
CC:
golang-codereviews, dave_cheney.net, gobot
Visibility:
Public.

Description

archive/tar: fix round-trip attributes The issue was identified while working with round trip FileInfo of the headers of hardlinks. Also, additional test cases for hard link handling.

Patch Set 1 #

Patch Set 2 : diff -r 4d78f41ca8c93c3ec3f51fc9fea3cbfe12b5af9e https://code.google.com/p/go #

Patch Set 3 : diff -r 4d78f41ca8c93c3ec3f51fc9fea3cbfe12b5af9e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -22 lines) Patch
M src/archive/tar/stat_unix.go View 1 1 chunk +30 lines, -11 lines 0 comments Download
M src/archive/tar/tar_test.go View 1 2 3 chunks +52 lines, -11 lines 0 comments Download
A src/archive/tar/testdata/hardlink.tar View 1 Binary file 0 comments Download
M src/archive/tar/writer_test.go View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 7
vbatts
Found an issue with round-tripping FileInfo of the Header of a hard linked file. Fixed ...
9 years, 6 months ago (2014-10-29 18:45:05 UTC) #1
vbatts
adding golang-codereviews
9 years, 6 months ago (2014-10-29 19:16:49 UTC) #2
dave_cheney.net
You have to hg mail 165860043 to initial the review process. http://golang.org/doc/contribute.html#tmp_13 Could you also ...
9 years, 6 months ago (2014-10-29 20:27:11 UTC) #3
vbatts
Fixes issue 9027
9 years, 6 months ago (2014-10-30 15:02:41 UTC) #4
vbatts
Hello golang-codereviews@googlegroups.com, dave@cheney.net (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2014-10-30 15:06:18 UTC) #5
gobot
R=golang-dev (assigned by dave@cheney.net)
9 years, 5 months ago (2014-12-04 04:04:46 UTC) #6
gobot
9 years, 4 months ago (2014-12-19 05:15:00 UTC) #7
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/165860043 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b