Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(174)

Issue 163055: code review 163055: Explicitly return values where it's shadowing the (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by cw
Modified:
14 years, 4 months ago
Reviewers:
CC:
rsc, dho, agl, agl1, ukai
Visibility:
Public.

Description

Explicitly return values where it's shadowing the parameter. Bad returns noticed by "Devon H. O'Dell" <devon.odell@gmail.com>. Resolves Issue 360.

Patch Set 1 : code review 163055: Explicitly return values where it's shadowing the #

Patch Set 2 : code review 163055: Explicitly return values where it's shadowing the #

Total comments: 2

Patch Set 3 : code review 163055: Explicitly return values where it's shadowing the #

Patch Set 4 : code review 163055: Explicitly return values where it's shadowing the #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/pkg/websocket/websocket.go View 1 2 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12
cw
Hello rsc, dho, agl, I'd like you to review the following change.
14 years, 4 months ago (2009-12-01 22:17:06 UTC) #1
dho
On 2009/12/01 22:17:06, cw wrote: > Hello rsc, dho, agl, > > I'd like you ...
14 years, 4 months ago (2009-12-01 22:18:07 UTC) #2
rsc
please also change the CL description to something you'd want to see in a hg ...
14 years, 4 months ago (2009-12-01 22:22:49 UTC) #3
cw
On Tue, Dec 01, 2009 at 10:22:49PM +0000, rsc@golang.org wrote: > please also change the ...
14 years, 4 months ago (2009-12-01 22:26:03 UTC) #4
rsc
let's go with this fix for now, since it is a fix, and let ukai ...
14 years, 4 months ago (2009-12-01 23:23:33 UTC) #5
cw
Hello rsc, dho, agl (cc: ukai), I'd like you to review the following change.
14 years, 4 months ago (2009-12-01 23:39:34 UTC) #6
agl
http://codereview.appspot.com/163055/diff/12/13 File src/pkg/websocket/websocket.go (right): http://codereview.appspot.com/163055/diff/12/13#newcode53 src/pkg/websocket/websocket.go:53: frameByte, ierr := ws.buf.ReadByte(); You don't need to rename ...
14 years, 4 months ago (2009-12-01 23:43:00 UTC) #7
cw
comment http://codereview.appspot.com/163055/diff/12/13 File src/pkg/websocket/websocket.go (right): http://codereview.appspot.com/163055/diff/12/13#newcode53 src/pkg/websocket/websocket.go:53: frameByte, ierr := ws.buf.ReadByte(); On 2009/12/01 23:43:00, agl ...
14 years, 4 months ago (2009-12-01 23:46:24 UTC) #8
cw
Hello rsc, dho, agl (cc: ukai), I'd like you to review the following change.
14 years, 4 months ago (2009-12-01 23:46:46 UTC) #9
agl1
*** Submitted as http://code.google.com/p/go/source/detail?r=852e85ed3218 *** Explicitly return values where it's shadowing the parameter. Bad returns ...
14 years, 4 months ago (2009-12-01 23:54:57 UTC) #10
ukai
Thanks!
14 years, 4 months ago (2009-12-02 02:12:09 UTC) #11
rsc
14 years, 4 months ago (2009-12-02 09:51:46 UTC) #12

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b