Added socketpair syscall and net.Socketpair.

Added socketpair syscall.

[Ivan Krasin, 2010-05-27 16:36:10]

http://codereview.appspot.com/1319042/diff/1/2
File src/pkg/net/sock.go (right):

http://codereview.appspot.com/1319042/diff/1/2#newcode15
src/pkg/net/sock.go:15: func Socketpair(domain int, typ int, protocol int) (fd
[]int, err os.Error) {
I know that this returning file descriptors sucks. Please propose the right
interface.

[rsc, 2010-05-27 16:37:55]

let's do two different CLs - one for the syscall and one for net.


On Thu, May 27, 2010 at 09:36,  <krasin@golang.org> wrote:
> Reviewers: rsc,
>
>
> http://codereview.appspot.com/1319042/diff/1/2
> File src/pkg/net/sock.go (right):
>
> http://codereview.appspot.com/1319042/diff/1/2#newcode15
> src/pkg/net/sock.go:15: func Socketpair(domain int, typ int, protocol
> int) (fd []int, err os.Error) {
> I know that this returning file descriptors sucks. Please propose the
> right interface.
>
> Description:
> Added socketpair syscall and net.Socketpair.
>
> Please review this at http://codereview.appspot.com/1319042/show
>
> Affected files:
>  src/pkg/net/sock.go
>  src/pkg/syscall/syscall_bsd.go
>  M src/pkg/syscall/syscall_linux.go
>  M src/pkg/syscall/syscall_linux_386.go
>  src/pkg/syscall/zerrors_darwin_386.go
>  src/pkg/syscall/zerrors_darwin_amd64.go
>  src/pkg/syscall/zerrors_freebsd_386.go
>  src/pkg/syscall/zerrors_freebsd_amd64.go
>  M src/pkg/syscall/zerrors_linux_386.go
>  M src/pkg/syscall/zerrors_linux_amd64.go
>  M src/pkg/syscall/zerrors_linux_arm.go
>  M src/pkg/syscall/zsyscall_darwin_386.go
>  M src/pkg/syscall/zsyscall_darwin_amd64.go
>  src/pkg/syscall/zsyscall_freebsd_386.go
>  M src/pkg/syscall/zsyscall_freebsd_amd64.go
>  M src/pkg/syscall/zsyscall_linux_amd64.go
>  M src/pkg/syscall/zsyscall_linux_arm.go
>
>
>

[Ivan Krasin, 2010-05-27 16:40:36]

Done

On 2010/05/27 16:37:55, rsc wrote:
> let's do two different CLs - one for the syscall and one for net.
> 
> 
> On Thu, May 27, 2010 at 09:36,  <mailto:krasin@golang.org> wrote:
> > Reviewers: rsc,
> >
> >
> > http://codereview.appspot.com/1319042/diff/1/2
> > File src/pkg/net/sock.go (right):
> >
> > http://codereview.appspot.com/1319042/diff/1/2#newcode15
> > src/pkg/net/sock.go:15: func Socketpair(domain int, typ int, protocol
> > int) (fd []int, err os.Error) {
> > I know that this returning file descriptors sucks. Please propose the
> > right interface.
> >
> > Description:
> > Added socketpair syscall and net.Socketpair.
> >
> > Please review this at http://codereview.appspot.com/1319042/show
> >
> > Affected files:
> > &nbsp;src/pkg/net/sock.go
> > &nbsp;src/pkg/syscall/syscall_bsd.go
> > &nbsp;M src/pkg/syscall/syscall_linux.go
> > &nbsp;M src/pkg/syscall/syscall_linux_386.go
> > &nbsp;src/pkg/syscall/zerrors_darwin_386.go
> > &nbsp;src/pkg/syscall/zerrors_darwin_amd64.go
> > &nbsp;src/pkg/syscall/zerrors_freebsd_386.go
> > &nbsp;src/pkg/syscall/zerrors_freebsd_amd64.go
> > &nbsp;M src/pkg/syscall/zerrors_linux_386.go
> > &nbsp;M src/pkg/syscall/zerrors_linux_amd64.go
> > &nbsp;M src/pkg/syscall/zerrors_linux_arm.go
> > &nbsp;M src/pkg/syscall/zsyscall_darwin_386.go
> > &nbsp;M src/pkg/syscall/zsyscall_darwin_amd64.go
> > &nbsp;src/pkg/syscall/zsyscall_freebsd_386.go
> > &nbsp;M src/pkg/syscall/zsyscall_freebsd_amd64.go
> > &nbsp;M src/pkg/syscall/zsyscall_linux_amd64.go
> > &nbsp;M src/pkg/syscall/zsyscall_linux_arm.go
> >
> >
> >
>

[Ivan Krasin, 2010-06-01 09:05:24]

Ping
On 2010/05/27 16:40:36, Ivan Krasin wrote:
> Done
> 
> On 2010/05/27 16:37:55, rsc wrote:
> > let's do two different CLs - one for the syscall and one for net.
> > 
> > 
> > On Thu, May 27, 2010 at 09:36,  <mailto:krasin@golang.org> wrote:
> > > Reviewers: rsc,
> > >
> > >
> > > http://codereview.appspot.com/1319042/diff/1/2
> > > File src/pkg/net/sock.go (right):
> > >
> > > http://codereview.appspot.com/1319042/diff/1/2#newcode15
> > > src/pkg/net/sock.go:15: func Socketpair(domain int, typ int, protocol
> > > int) (fd []int, err os.Error) {
> > > I know that this returning file descriptors sucks. Please propose the
> > > right interface.
> > >
> > > Description:
> > > Added socketpair syscall and net.Socketpair.
> > >
> > > Please review this at http://codereview.appspot.com/1319042/show
> > >
> > > Affected files:
> > > &nbsp;src/pkg/net/sock.go
> > > &nbsp;src/pkg/syscall/syscall_bsd.go
> > > &nbsp;M src/pkg/syscall/syscall_linux.go
> > > &nbsp;M src/pkg/syscall/syscall_linux_386.go
> > > &nbsp;src/pkg/syscall/zerrors_darwin_386.go
> > > &nbsp;src/pkg/syscall/zerrors_darwin_amd64.go
> > > &nbsp;src/pkg/syscall/zerrors_freebsd_386.go
> > > &nbsp;src/pkg/syscall/zerrors_freebsd_amd64.go
> > > &nbsp;M src/pkg/syscall/zerrors_linux_386.go
> > > &nbsp;M src/pkg/syscall/zerrors_linux_amd64.go
> > > &nbsp;M src/pkg/syscall/zerrors_linux_arm.go
> > > &nbsp;M src/pkg/syscall/zsyscall_darwin_386.go
> > > &nbsp;M src/pkg/syscall/zsyscall_darwin_amd64.go
> > > &nbsp;src/pkg/syscall/zsyscall_freebsd_386.go
> > > &nbsp;M src/pkg/syscall/zsyscall_freebsd_amd64.go
> > > &nbsp;M src/pkg/syscall/zsyscall_linux_amd64.go
> > > &nbsp;M src/pkg/syscall/zsyscall_linux_arm.go
> > >
> > >
> > >
> >

[rsc1, 2010-06-01 21:30:06]

This looks pretty good.
There should be a stub in syscall_nacl.go too, right?

The PF constants seem unnecessary.
They're always the same as the AF constants,
so maybe just use the AF ones that already exist?

[Ivan Krasin, 2010-06-18 11:03:47]

On 2010/06/01 21:30:06, rsc1 wrote:
> This looks pretty good.
> There should be a stub in syscall_nacl.go too, right?
I don't know. 

1. Go NaCl support is completely broken now
2. It will be much updated after NaCl gets shared libraries and jit support
3. It will even more updated after PNaCl is out of alpha.

I would prefer do not touch NaCl part until we get PNaCl and JIT support. After
that I promise to deliver PNaCl support for Go, because I have plans to use it
in my main project. Ask me at krasin@google.com for more details.

If you still think that I should add this syscall to
> 
> The PF constants seem unnecessary.
> They're always the same as the AF constants,
> so maybe just use the AF ones that already exist?
Done

[Ivan Krasin, 2010-06-18 12:06:35]

On 2010/06/18 11:03:47, Ivan Krasin wrote:
> On 2010/06/01 21:30:06, rsc1 wrote:
> > This looks pretty good.
> > There should be a stub in syscall_nacl.go too, right?
> I don't know. 
> 
> 1. Go NaCl support is completely broken now
> 2. It will be much updated after NaCl gets shared libraries and jit support
> 3. It will even more updated after PNaCl is out of alpha.
> 
> I would prefer do not touch NaCl part until we get PNaCl and JIT support.
After
> that I promise to deliver PNaCl support for Go, because I have plans to use it
> in my main project. Ask me at mailto:krasin@google.com for more details.
> 
> If you still think that I should add this syscall to
the CL, let me know.

Sorry for truncating the message.
> > 
> > The PF constants seem unnecessary.
> > They're always the same as the AF constants,
> > so maybe just use the AF ones that already exist?
> Done

[imkrasin, 2010-06-18 17:27:05]

Russ,

take a look again, please.

Ivan

On Wed, Jun 2, 2010 at 1:30 AM,  <rsc@google.com> wrote:
> This looks pretty good.
> There should be a stub in syscall_nacl.go too, right?
>
> The PF constants seem unnecessary.
> They're always the same as the AF constants,
> so maybe just use the AF ones that already exist?
>
>
> http://codereview.appspot.com/1319042/show
>

[imkrasin, 2010-06-21 10:13:56]

Ping

On Fri, Jun 18, 2010 at 9:27 PM, Ivan Krasin <imkrasin@gmail.com> wrote:
> Russ,
>
> take a look again, please.
>
> Ivan
>
> On Wed, Jun 2, 2010 at 1:30 AM,  <rsc@google.com> wrote:
>> This looks pretty good.
>> There should be a stub in syscall_nacl.go too, right?
>>
>> The PF constants seem unnecessary.
>> They're always the same as the AF constants,
>> so maybe just use the AF ones that already exist?
>>
>>
>> http://codereview.appspot.com/1319042/show
>>
>

[rsc1, 2010-06-30 21:55:54]

LGTM

Thanks.

[rsc, 2010-06-30 21:58:23]

*** Submitted as http://code.google.com/p/go/source/detail?r=982df2b2cb4b ***

syscall: add socketpair

R=rsc
CC=golang-dev
http://codereview.appspot.com/1319042

Committer: Russ Cox <rsc@golang.org>